- 
                Notifications
    
You must be signed in to change notification settings  - Fork 4.8k
 
OCPNODE-3138: Add zstd:chunked image test #29713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           @bitoku: This pull request references OCPNODE-3138 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.  | 
    
9f10ae6    to
    2b816c9      
    Compare
  
    | 
          
 Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 2b816c9 
 New tests seen in this PR at sha: 2b816c9 
  | 
    
ff88ff0    to
    d7259a2      
    Compare
  
    | 
          
 Job Failure Risk Analysis for sha: d7259a2 
 Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: d7259a2 
 New tests seen in this PR at sha: d7259a2 
  | 
    
| 
          
 Job Failure Risk Analysis for sha: da41246 
 Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: da41246 
 New tests seen in this PR at sha: da41246 
  | 
    
| 
           @bitoku: This pull request references OCPNODE-3138 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.  | 
    
| 
           /retest-required  | 
    
| 
          
 Job Failure Risk Analysis for sha: 7681d59 
 Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 7681d59 
 New tests seen in this PR at sha: 7681d59 
  | 
    
| 
          
 Job Failure Risk Analysis for sha: 175d33f 
  | 
    
| 
           /retest-required  | 
    
| 
          
 Job Failure Risk Analysis for sha: 65916a0 
 Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 65916a0 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor nits.
Overall LGTM
| 
           /skip  | 
    
| 
          
 Job Failure Risk Analysis for sha: fb17b41 
 Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: fb17b41 
  | 
    
Signed-off-by: Ayato Tokubi <[email protected]>
| 
           /retest-required  | 
    
| 
           /skip  | 
    
| 
           /retest-required  | 
    
| 
           /retest  | 
    
| 
           /approve Approval for the mechanics of the PR and changes to the root dir. You'll want someone from node team to lgtm  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add OWNERS file wherever necessary?
@asahay19 has been trying to get the PR having a node sub-dir created. Just make sure there are no conflicts
https://github.com/openshift/origin/pull/29640/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| 
           [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, sairameshv, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
      
 Approvers can indicate their approval by writing   | 
    
| 
           @bitoku: The following tests failed, say  
 Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.  | 
    
| 
          
 Job Failure Risk Analysis for sha: 2572939 
 Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 2572939 
 New tests seen in this PR at sha: 2572939 
  | 
    
Fixes https://issues.redhat.com/browse/OCPNODE-3138